Add support for the RISC-V architecture #53508
Conversation
| # It's also only relevant for tools build and desktop platforms, | ||
| # as doing lightmap generation and denoising on Android or HTML5 | ||
| # would be a bit far-fetched. | ||
| desktop_platforms = ["linuxbsd", "osx", "windows"] | ||
| return env["tools"] and platform in desktop_platforms and env["bits"] == "64" and env["arch"] != "arm64" | ||
| supported_arch = env["bits"] == "64" and env["arch"] != "arm64" and not env["arch"].startswith("rv") |
There was a problem hiding this comment.
Why isn't this
| supported_arch = env["bits"] == "64" and env["arch"] != "arm64" and not env["arch"].startswith("rv") | |
| supported_arch = env["bits"] == "64" and env["arch"] != "arm64" and env["arch"] != "rv64" |
?
There was a problem hiding this comment.
In the future we might want to allow specifying a custom -march string, like "rv64gcv". There's not a lot of use for this at the moment so I didn't bother supporting it in the SConstruct file, but the startswith check is a simple improvement over checking string inequality that will work for that case. Plus it's possible that someone would want to make a 32-bit or 128-bit version, and startswith also works for that case with no downsides.
aaronfranke
force-pushed
the
riscv
branch
3 times, most recently
from
393d0f5
to
f4e360f
Compare
aaronfranke
force-pushed
the
riscv
branch
2 times, most recently
from
1c0969e
to
ef4b2d0
Compare
platform/linuxbsd/detect.py
Outdated
| @@ -1,6 +1,7 @@ | |||
| import os | |||
| import platform | |||
| import sys | |||
| from platform import machine | |||
There was a problem hiding this comment.
Nitpick, but since we import platform already, I'd prefer simply using platform.machine() instead of re-importing it.
There was a problem hiding this comment.
Good catch, this was just a blind copy from SConstruct so I missed that we already import platform.
Supports RV64GC (RISC-V 64-bit with general-purpose and compressed-instruction extensions)
|
Thanks! |
Implements godotengine/godot-proposals#3374 on master. Only Clang Debug builds work on RISC-V right now.